Formal proposal: move -Wall from --enable-developer to default

[John H Terpstra]

On Wednesday 30 March 2005 10:46, Gerald (Jerry) Carter wrote:
> Gerald (Jerry) Carter wrote:
> | (moving to samba-technical list).
> |
> | derrell at samba.org wrote:
> | | Would anyone mind if I modify configure to put -Wall in
> | | the default set of CFLAGS without the requirement of
> | | specifying --enable-developer?  I believe this will
> | | help us all to generate cleaner code and find certain
> | | bugs more expeditiously.
> |
> | I'd rather not.  All developers generally use this which is who
> | you want to see the warnings.  adding -Wall to the general
> | build will generate a lot more (mostly unnecessary noise)
> | when admins.  I'm fine with moving the default in SAMBA_3_0
> | to set --enable-developer=yes, but I don't want to change this
> | default in the release branch.
>
> a little bit of history is necessary as well....
>
> Previously the MIT krb5 headers generated hige amounts of
> of warnings.  We can't do much about that.  So there is also
> the --enable-krb5-developer option.
>
> Derrell, I have not problem setting --enable-developer=yes
> as the default in truink and SAMBA_3_0 but I will not
> include this change in the _RELEASE tree.

Please, please do not set the -Wall or the --eneable-developer=yes in 
SAMBA_3_0. In trunk this is OK, but please not in the SAMBA_3_0 branch as I 
deal with enough noise now (both from compilation and from users who contact 
me about simple warning messages).

- John T.