Formal proposal: move -Wall from --enable-developer to default

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Richard Sharpe wrote:
| On Wed, 30 Mar 2005, Gerald (Jerry) Carter wrote:
|
|>derrell at samba.org wrote:
|>
|>| Would anyone mind if I modify configure to put -Wall in
|>| the default set of CFLAGS without the requirement of
|>| specifying --enable-developer?  I believe this will
|>| help us all to generate cleaner code and find certain
|>| bugs more expeditiously.
|>
|>I'd rather not.  All developers generally use this which is who
|>you want to see the warnings.  adding -Wall to the general
|>build will generate a lot more (mostly unnecessary noise)
|>when admins.  I'm fine with moving the default in SAMBA_3_0
|>to set --enable-developer=yes, but I don't want to change this
|>default in the release branch.
|
| I would expect it to generate lots more bugs as well ...

Assuming you mean bug reports here.  And I agree.  But if they
are legitimate bugs, then that would be good.  But I think we
would see a lot of reports about the const cast warnings.

To be honest, I doubt it is really necessary to set
- --enable-developer as the default given that we pretty much
all do that anyways.

I really should write that new developer HOWTO though.  And the
new team member HOWTO.




cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCSuUKIR7qMdg1EfYRAlkmAJ9yCXjTUiMmBFL52pFGW7cJsvR7+ACgo3x7
46gBCri/uTmt8y9iOu+SIPg=
=PuXD
-----END PGP SIGNATURE-----