Formal proposal: move -Wall from --enable-developer to default

[Richard Sharpe]

On Wed, 30 Mar 2005, Gerald (Jerry) Carter wrote:

> |>derrell at samba.org wrote:
> |>
> |>| Would anyone mind if I modify configure to put -Wall in
> |>| the default set of CFLAGS without the requirement of
> |>| specifying --enable-developer?  I believe this will
> |>| help us all to generate cleaner code and find certain
> |>| bugs more expeditiously.
> |>
> |>I'd rather not.  All developers generally use this which is who
> |>you want to see the warnings.  adding -Wall to the general
> |>build will generate a lot more (mostly unnecessary noise)
> |>when admins.  I'm fine with moving the default in SAMBA_3_0
> |>to set --enable-developer=yes, but I don't want to change this
> |>default in the release branch.
> |
> | I would expect it to generate lots more bugs as well ...
>
> Assuming you mean bug reports here.  And I agree.  But if they
> are legitimate bugs, then that would be good.  But I think we
> would see a lot of reports about the const cast warnings.

Sigh, yes, that is what I meant.

That is, we will get lots of the same bug reports telling us that some
line discards the const attribute or something like that, because people
don't check to see if the same bug is already logged.

Regards
-----
Richard Sharpe, rsharpe[at]richardsharpe.com, rsharpe[at]samba.org,
sharpe[at]ethereal.com, http://www.richardsharpe.com