directory change notification patch

Derrell.Lipman at UnwiredUniverse.com Derrell.Lipman at UnwiredUniverse.com
Mon Mar 28 03:19:29 GMT 2005


Jeremy Allison <jra at samba.org> writes:

> Sometime having your source code out there *sucks* :-) :-).  Especially when
> it has subtle bugs (and I'm saying they're subtle 'cos this stuff has been
> out there forever and no-one else noticed :-).

Really good engineers tend to be both highly opinionated and very defensive of
their code, because in the vast majority of cases, their opinion ends up being
the right way to go, and their code ends up being correct. :-)

Now the question is, do you agree with the priority that Mark gave in his
patch?  Do interrupts deserve higher priority than data, as he indicated?  I
believe they do.  Is his patch the best way to implement the fix?  I have not
evaluated Mark's patch in detail to see specifically what he did; rather I
verified that his explanation of the problem matched the existing code.  I
take it you'll probably want to review (or already have reviewed) Mark's patch
now...

Check one more bug (albeit previously unrecognized) off the list. :-)

Cheers,

Derrell


More information about the samba-technical mailing list