A small patch for C++ VFS modules.

Jeremy Allison jra at samba.org
Thu Jun 23 16:05:52 GMT 2005

On Thu, Jun 23, 2005 at 04:35:19PM +0400, Alexander Bokovoy wrote:
> On Thu, Jun 23, 2005 at 06:04:46PM +1000, Ben Martin wrote:
> > > >  		int (*fstat)(struct vfs_handle_struct *handle, struct files_struct *fsp, int fd, SMB_STRUCT_STAT *sbuf);
> > > Any change in VFS layer require increasing VFS version number.
> > 
> > I'm not sure I follow here, if changes are limited to renaming 
> > "char* new" -> "char* newstr" 
> > in the header doesn't that retain all VFS version number compatibility?
> Technically, yes. But from maintenance point of view we need to record any
> changes so that even source-level compatibility is enforced by refusing to
> load binary modules built for previous version of VFS. It would make
> module provider more attentive to what happens in main VFS API.

Nah, he's right and you're wrong on this Alexander. Just changing a
parameter name from new to new_str doesnt' warrent a VFS number change.
It has no impact on any existing VFS modules.


More information about the samba-technical mailing list