svn commit: samba r8178 - in trunk/source/smbd: .

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Jul 6 12:57:08 GMT 2005

On Wed, Jul 06, 2005 at 04:55:24AM -0700, Jeremy Allison wrote:
> Also you're not doing lock_share_entry() / unlock_share_entry() before
> getting the share modes. We could read an inconsistent state. I don't
> think this is right...

Hmmm. I don't really see that point. I don't want to change anything, *just*
read. I thought that tdb_fetch/tdb_store as such are atomic. When looking at
for example mod_share_mode(), this does a fetch, modifies all in memory, and
then does a tdb_store(). So if I caught it in between, I get the unmodified

What is wrong here?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url :

More information about the samba-technical mailing list