svn commit: samba r8178 - in trunk/source/smbd: .

Jeremy Allison jra at samba.org
Thu Jul 7 01:27:54 GMT 2005


On Wed, Jul 06, 2005 at 02:57:08PM +0200, Volker Lendecke wrote:
> 
> Hmmm. I don't really see that point. I don't want to change anything, *just*
> read. I thought that tdb_fetch/tdb_store as such are atomic. When looking at
> for example mod_share_mode(), this does a fetch, modifies all in memory, and
> then does a tdb_store(). So if I caught it in between, I get the unmodified
> state.
> 
> What is wrong here?

Nothing, you are right and I am wrong. I have looked carefully
at the tdb_store code and you are correct, sorry. We need to do
the lock_XX / unlock_XX if we need it to be consistent between
modifications, but not when looking at a snapshot.

Thanks,

	Jeremy.


More information about the samba-technical mailing list