svn commit: samba r5580 - in branches/SAMBA_3_0/source: include rpc_parse rpc_server utils

[Stefan (metze) Metzmacher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bartlett schrieb:
| On Sat, 2005-02-26 at 15:26 +0000, jmcd at samba.org wrote:
| +	/* search for the secret record */
| +	ret = samdb_search(ldb,
| +			   mem_ctx, base_dn, &msgs, attrs_secret,
| +			   "(&(cn=%s Secret)(&(objectclass=secret)))",
| +			   r->generic.in.domain_name);
| +	if (ret == 0) {
| +		msg = ldb_msg_new(mem_ctx);
| +		msg->dn = talloc_asprintf(mem_ctx, "cn=%s Secret,%s",
| +					  r->generic.in.domain_name,
| +					  base_dn);

the string "cn=DOMAIN Secret"
| +		samdb_msg_set_string(ldb, mem_ctx, msg, "cn", r->generic.in.domain_name);

doesn't match "cn=DOMAIN", I think they neet to match.

| +	ret = samdb_search(ldb,
| +			   mem_ctx, base_dn, &msgs_trusted_domain, attrs_secret,
| +			   "(&(cn=%s)(&(objectclass=trustedDomain)))",
| +			   r->generic.in.domain_name);
| +	if (ret == 0) {
| +		msg = ldb_msg_new(mem_ctx);
| +		msg->dn = talloc_asprintf(mem_ctx, "cn=%s,%s",
| +					  r->generic.in.domain_name,
| +					  base_dn);
| +		samdb_msg_set_string(ldb, mem_ctx, msg, "cn", r->generic.in.domain_name);
| +		samdb_msg_add_string(ldb, mem_ctx, msg, "objectClass", "trustedDomain");

here it matches...

So the "cn=%s Secret,%s" should be also "cn=%s,%s"
I think this is what w2k3 also uses

the rest looks good:-)

- --
metze

Stefan Metzmacher <metze at samba.org> www.samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3-nr1 (Windows XP)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCIstgm70gjA5TCD8RAktPAJ9ryrzPi2O+30FlztaQz1l2g0hM4ACfc2k5
Yi3eBHZhAFFJHmsl9jcJOGU=
=zQCH
-----END PGP SIGNATURE-----