segv in svn

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jeremy,

There's a segv in user_can_read_file() which I think
is probably due to the recent delete changes.  It's
reproducible when you set 'hide unreadable = yes'.
I can just add a checj before dereferencing the pst
pointer but I think you might want to look at it further.




cheers, jerry


Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 1078626176 (LWP 9743)]
0x0808cafa in user_can_read_file (conn=0x83af028, name=0x83ad668
".//windows_98.iso", pst=0x0) at smbd/dir.c:789
789 if (!VALID_STAT(*pst) && (SMB_VFS_STAT(conn, name, pst) != 0))

(gdb) print pst
$4 = (struct stat *) 0x0


(gdb) bt
#0  0x0808cafa in user_can_read_file (conn=0x83af028, name=0x83ad668
".//windows_98.iso", pst=0x0) at smbd/dir.c:789
#1  0x0808cf38 in is_visible_file (conn=0x83af028, dir_path=0x839d4a0
"./", name=0x83a0918 "windows_98.iso", pst=0x0,
~    use_veto=1) at smbd/dir.c:923
#2  0x0808bf33 in dptr_normal_ReadDirName (dptr=0x839d418,
poffset=0xbfffdbc0, pst=0xbfffe810) at smbd/dir.c:512
#3  0x0808bf89 in dptr_ReadDirName (dptr=0x839d418, poffset=0xbfffdbc0,
pst=0xbfffe810) at smbd/dir.c:529
#4  0x080bad71 in get_lanman2_dir_entry (conn=0x83af028,
inbuf=0x40561008, outbuf=0x406d4008, path_mask=0xbfffe990 "*",
~    dirtype=22, info_level=260, requires_resume_key=4, dont_descend=0,
ppdata=0xbfffe98c, base_data=0x83afa50 "`",
~    space_remaining=16448, out_of_space=0xbfffe970,
got_exact_match=0xbfffe8f8, last_name_off=0xbfffe988) at smbd/trans2.c:856
#5  0x080bd5fb in call_trans2findfirst (conn=0x83af028, inbuf=0x40561008
"", outbuf=0x406d4008 "", bufsize=131072,
~    pparams=0xbffff23c, total_params=18, ppdata=0xbffff238,
total_data=0, max_data_bytes=16644) at smbd/trans2.c:1452
#6  0x080c7a81 in reply_trans2 (conn=0x83af028, inbuf=0x40561008 "",
outbuf=0x406d4008 "", length=90, bufsize=131072)
~    at smbd/trans2.c:4401
#7  0x080e2cc6 in switch_message (type=50, inbuf=0x40561008 "",
outbuf=0x406d4008 "", size=90, bufsize=131072)
~    at smbd/process.c:968
#8  0x080e2d85 in construct_reply (inbuf=0x40561008 "",
outbuf=0x406d4008 "", size=90, bufsize=131072) at smbd/process.c:998
#9  0x080e30fd in process_smb (inbuf=0x40561008 "", outbuf=0x406d4008
"") at smbd/process.c:1098
#10 0x080e3f48 in smbd_process () at smbd/process.c:1558
#11 0x08284d19 in main (argc=4, argv=0xbffff554) at smbd/server.c:951


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCG1HFIR7qMdg1EfYRAg2TAKCjt/CESModT3R8wJYIJvY4OS+JTgCg81JQ
m7Y7uqZNrSg4GFKzKcmYLSQ=
=lhwC
-----END PGP SIGNATURE-----