segv in svn

[Jeremy Allison]

On Tue, Feb 22, 2005 at 09:37:41AM -0600, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Jeremy,
> 
> There's a segv in user_can_read_file() which I think
> is probably due to the recent delete changes.  It's
> reproducible when you set 'hide unreadable = yes'.
> I can just add a checj before dereferencing the pst
> pointer but I think you might want to look at it further.

This is the fix (ZERO_STRUCT instead of ZERO_STRUCTP).
Sorry.

Jeremy.

Index: smbd/dir.c
===================================================================
--- smbd/dir.c  (revision 5505)
+++ smbd/dir.c  (working copy)
@@ -902,7 +902,7 @@
        BOOL hide_unwriteable = lp_hideunwriteable_files(SNUM(conn));
        BOOL hide_special = lp_hide_special_files(SNUM(conn));
  
-       ZERO_STRUCT(pst);
+       ZERO_STRUCTP(pst);
  
        if ((strcmp(".",name) == 0) || (strcmp("..",name) == 0)) {
                return True; /* . and .. are always visible. */