'make test' in Samba 3

Gerald (Jerry) Carter jerry at samba.org
Thu Aug 25 13:39:34 GMT 2005

Hash: SHA1

Volker Lendecke wrote:
> On Wed, Aug 24, 2005 at 09:08:11AM -0500, Gerald (Jerry) Carter wrote:
>>I think the infrastructure for 'make test' is workable
>>in the SAMBA_3_0 tree now.  If you could make sure that
>>it runs ok for you, that would be great.  There's only a
>>couple of tests right now.
> If these tests become more and more restarting smbd after 
> every test might make that a bit too long. Why is that necessary?

Good question.  I just started with the assumption that
a test would scripted in an individual file making it easy
to manually run a single test via

'cd source; scripts/test/runtests.sh t_dir 001'

However, the main lag in in verifying that smbd has
stopped (see functions:stop_smbd()) since the smbcontrol
has to timeout under the normal circumstances.
We could trim the timeout some.  It defaults to 10
seconds in utils/smbcontrol.c.

The 'smbcontrol smbd ping' was the most portable way I
could think of to determine whether or not smbd was still
running.  if we have a single pid, 'kill -0 <pid>' is quicker.

If we don't want to have the one test per t_XXX.sh file, then
the only real reason to have separate files would be when we
need to use a different smb.conf file.

cheers, jerry
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org


More information about the samba-technical mailing list