large writes and reads ...

Richard Sharpe rsharpe at
Fri Oct 15 18:30:54 GMT 2004


Well, it seems that both reply_read_and_X and reply_write_and_X in
smbd/reply.c for the current Samba 3 code ignores large reads and writes.

That is, they both ignore the Max Count High field for reads and the Data
Length High field for writes if the WCT is not 14 for each of these.

Indeed, reply_read_and_X ignores the Max Count High field altogether, as
all it does is:

        size_t smb_maxcnt = SVAL(inbuf,smb_vwv5);

and does not add in the high field under any circumstances, even though
Samba claims to support Large Read&X in the capabilities field of the
NegProt response.

The code in reply_write_and_X only pays attention to the Lenght High Field
if the WCT is 14, which seems just wrong ...

I propose fixing this to see if it improves reading and writing speed.

Richard Sharpe, rsharpe[at], rsharpe[at],

More information about the samba-technical mailing list