samba4: unsigned char -> uint8
abartlet at samba.org
Sat May 29 12:35:45 GMT 2004
On Sat, 2004-05-29 at 21:55, Andrew Bartlett wrote:
> On Sat, 2004-05-29 at 18:19, Stefan (metze) Metzmacher wrote:
> > Andrew Bartlett schrieb:
> > > On Sat, 2004-05-29 at 09:03, tridge at samba.org wrote:
> > >
> > >>Metze,
> > >>
> > >> > any objections when I convert 'unsigned char' to uint8
> > >> > in samba4
> > >> >
> > >> > and 'unsigned' and 'unsigned int' to uint_t.
> > >>
> > >>That's OK with me.
> > >
> > >
> > > Lets just make sure we don't take it too far - I don't want to see all
> > > our string becoming 'int8 *' ;-)
> > I think 'int' and 'char' should be used in samba4.
Then why not 'unsigned char'. But you have already committed that
> > > Personally, I don't see the point in the short names for 'unsigned
> > > int'. I understand the need for explicit 64 bit names in particular
> > > (where various compilers call it a different thing) but what exactly was
> > > wrong with 'unsigned int'?
> > There's nothing wrong, but I think it would be usefull to a minal
> > set of basic data types we use in samba4.
> > That will make our configure tests uch easier.
> > And also we currently have inside some structs one filed as 'unsigned'
> > and another one as 'unsigned int' and maybe another as 'uint_t',
> > and that's VERY confusing for someone to read that code!
> > in samba4 we'll install a lot of header files to the system and other
> > projects will use them, so that's another reason for making the stuf
> > easier and better to follow...
> Well, if we are going to keep 'int', then lets make the matching type
> 'unsigned int' not 'uint_t', for consistency.
There seems to be some '_t' is better syndrome. Why exactly is that?
What is wrong with the historic, provided types, where the particular
size doesn't matter?
Andrew Bartlett abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team abartlet at samba.org
Student Network Administrator, Hawker College abartlet at hawkerc.net
http://samba.org http://build.samba.org http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20040529/e3586f27/attachment.bin
More information about the samba-technical