smbcacls/smbcquotas oddities

[Tim Potter]

On Fri, 2004-12-17 at 23:01 +0100, Pascal Terjan wrote:
> Hi,
> This afternoon I forgot // at the beginning of //server/share when
> running smbcacls. I noticed that smbcals dropped the first 2 chars even
> if it is not //. So, I looked into the code, planning to add a test. I
> noticed 2 strange things :
> 
> 1) While most utils use a fstring for server name, smbcquotas.c uses a
> pstring

Probably a bug, although it's unlikely it will ever be triggered as
server names are usually quite short.

> 2) In smbcacls.c line 838, what's the goal of strchr_m(server,'/') if
> all / got replaced few lines before ?

Probably a bug as well.

If you fix them file a bugzilla bug or post a patch to the mailing list
and I will apply it.


Tim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20041219/101ac4a4/attachment.bin