CVS update: samba/source/nsswitch

Gerald (Jerry) Carter jerry at samba.org
Sun Sep 7 13:10:58 GMT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 7 Sep 2003, Andrew Bartlett wrote:

> I assume you checked it all out with valgrind - but this really looks
> like a double-free to me.  It also looks like a write to invalid memory,
> when after winbind_cm_flush(), we set cli->fd = -1.
> 
> (Because winbind_cm_flush() calls cli_shutdown(), which is the normal
> way to free a cli pointer).
> 
> What am I missing?

If you see a bug, then fix it.  Just make sure you test it.

I didn't run it under valgrind.  But I did test it and didn't find any 
segfaults.  I'm waiting on feedback from from the bug reporter as well.




cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.0 (GNU/Linux)
Comment: For info see http://quantumlab.net/pine_privacy_guard/

iD8DBQE/Wy5lIR7qMdg1EfYRAvlXAJ4pEtSksfjOIF4VAjQ9eBVfwOaUEACfRxfH
pmWjFckv43ZqlTLAsFfWh0s=
=yahw
-----END PGP SIGNATURE-----




More information about the samba-technical mailing list