CVS update: samba/source/nsswitch

Andrew Bartlett abartlet at samba.org
Sun Sep 7 05:20:24 GMT 2003


On Sun, 2003-09-07 at 05:49, jerry at samba.org wrote:
> Date:	Sat Sep  6 19:49:59 2003
> Author:	jerry
> 
> Update of /data/cvs/samba/source/nsswitch
> In directory dp.samba.org:/tmp/cvs-serv27385/nsswitch
> 
> Modified Files:
>       Tag: SAMBA_3_0
> 	winbindd_pam.c 
> Log Message:
> fix bug 382: make sure to free and reset the cli_state pointer after flushing connections in winbindd_pam_auth[_crap]()

I assume you checked it all out with valgrind - but this really looks
like a double-free to me.  It also looks like a write to invalid memory,
when after winbind_cm_flush(), we set cli->fd = -1.

(Because winbind_cm_flush() calls cli_shutdown(), which is the normal
way to free a cli pointer).

What am I missing?

Andrew Bartlett
-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20030907/632d89b2/attachment.bin


More information about the samba-technical mailing list