[patch] uppercase workgroup in browse request

[Stephan Kulow]

Am Thursday 27 March 2003 18:04 schrieb Christopher R. Hertel:
> On Thu, Mar 27, 2003 at 05:43:55PM +0100, Stephan Kulow wrote:
> > Am Thursday 27 March 2003 03:43 schrieb Christopher R. Hertel:
> > > Stephan Kulow wrote:
> > > > Hi!
> > > >
> > > > I noticed a difference between testsmbc "smb://MYGRP" and testsmbc
> > > > "smb://mygrp" (it doesn't make a difference for SAMBA servers, but it
> > > > does for XP and for winME) So please apply the included patch.
> > >
> > > Hang on...
> > >
> > > Do I read this correctly?  Are we forgetting to up-case the workgroup
> > > name? (...it always helps to provide a little clue along with the
> > > patch.)  :)
> > >
> > > Samba decodes NetBIOS names and then performs a case-insensitive
> > > comparison on the original name.  Windows (the versions I've tested)
> > > simply compares the wire-format strings.  That's faster, but it's also
> > > case sensitive.  I don't currently have any ME or XP systems to test.
> >
> > I don't understand. You seem to agree with the patch, still it's not
> > applied.
>
> I don't understand.  I asked for clarification.  :)
>
> There's a question above.  I asked "Do I read this correctly?".
You added a smiley behind it, so it appeared ironicly to me.
>
> So, what is your intention with this patch?  What was the problem you were
> detecting?  You never specified.  Before I dig into the patch I want to
> know what you are trying to accomplish.
>
Well, host names in URLs are usually case insensitive and with samba servers
smb://mygrp gives indeed the same as smb://MYGRP. But not when the server
is running winME, win98 or XP (that's the versions I tried). As KDE's URL 
handling lower cases the host part (and that's what "MYGRP" is), you'll 
notice.

Meanwhile Andrew pointed out that my patch wasn't safe, so I changed it to
use STR_UPPER.

Greetings, Stephan

-- 
Pace, Peace, Paix, Paz, Frieden, Pax, Pokój