[patch] uppercase workgroup in browse request

[Christopher R. Hertel]

On Thu, Mar 27, 2003 at 05:43:55PM +0100, Stephan Kulow wrote:
> Am Thursday 27 March 2003 03:43 schrieb Christopher R. Hertel:
> > Stephan Kulow wrote:
> > > Hi!
> > >
> > > I noticed a difference between testsmbc "smb://MYGRP" and testsmbc
> > > "smb://mygrp" (it doesn't make a difference for SAMBA servers, but it
> > > does for XP and for winME) So please apply the included patch.
> >
> > Hang on...
> >
> > Do I read this correctly?  Are we forgetting to up-case the workgroup name?
> > (...it always helps to provide a little clue along with the patch.)  :)
> >
> > Samba decodes NetBIOS names and then performs a case-insensitive comparison
> > on the original name.  Windows (the versions I've tested) simply compares
> > the wire-format strings.  That's faster, but it's also case sensitive.  I
> > don't currently have any ME or XP systems to test.
> >
> I don't understand. You seem to agree with the patch, still it's not applied.

I don't understand.  I asked for clarification.  :)

There's a question above.  I asked "Do I read this correctly?".

So, what is your intention with this patch?  What was the problem you were
detecting?  You never specified.  Before I dig into the patch I want to
know what you are trying to accomplish.

Chris -)-----

-- 
Samba Team -- http://www.samba.org/     -)-----   Christopher R. Hertel
jCIFS Team -- http://jcifs.samba.org/   -)-----   ubiqx development, uninq.
ubiqx Team -- http://www.ubiqx.org/     -)-----   crh at ubiqx.mn.org
OnLineBook -- http://ubiqx.org/cifs/    -)-----   crh at ubiqx.org