[PATCH] Better fix for devicetype?
jra at dp.samba.org
jra at dp.samba.org
Tue Mar 25 17:36:38 GMT 2003
On Tue, Mar 25, 2003 at 10:02:13PM +1100, Andrew Bartlett wrote:
> Would this be a better fix for the devicetype problem?
>
> It looks like we are putting the strings into the buffer twice, and we
> are not returning the 'fixed' devicetype for both protocol levels (< NT1
> and NT1).
>
> What happened here is that jermey 'fixed' a const warning. This meant
> that this 'in/out' buffer became an 'in' buffer, and we didn't push the
> correct devicetype back to the wire.
Well it wasn't so much a warning as a bug. We were passing quoted
strings into that function in some cases, so writing into them was not recommended :-).
Jeremy.
More information about the samba-technical
mailing list