CVS update: samba/source/lib

Andrew Bartlett abartlet at
Sun Jul 27 05:00:38 GMT 2003

On Sun, 2003-07-27 at 13:24, Tim Potter wrote:
> On Sun, Jul 27, 2003 at 02:28:25AM +0000, abartlet at wrote:
> > Modified Files:
> >       Tag: SAMBA_3_0
> > 	charcnv.c 
> > Log Message:
> > Some small fixes to our charset conversion code:
> > 
> >  - Treat the NMB names in the 'session request' packet as 'ASCII'.  This means
> >    that we do not get invalid multibyte from the wire, even if we truncate
> >    in the conversion.  (Otherwise we panic when we try to strupper_m it).
> This will probably break netbios names containing international
> characters.  Unfortunately Netbios names are in the dos codepage of the
> client so there isn't a lot left to break (-: but it is supposed to work
> amongst clients with identical dos codpages.

Sorry, i should have made that clearer - it's ascii as in pull_ascii,
which is DOS codepage.

This is just for smbd - for nmbd I recon we need to revert to comparing
encoded strings.

Andrew Bartlett

Andrew Bartlett                                 abartlet at
Manager, Authentication Subsystems, Samba Team  abartlet at
Student Network Administrator, Hawker College   abartlet at
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url :

More information about the samba-technical mailing list