Patches for winbindd_ads.c

Gerald (Jerry) Carter jerry at samba.org
Sun Jul 13 01:40:31 GMT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sat, 12 Jul 2003, Ken Cross wrote:

> Samba-folk:
> 
> Attached are two patches to winbindd_ads.c.
> 
> The first fixes this error:
> 
>  [2003/07/06 13:45:05, 1] nsswitch/winbindd_ads.c:enum_dom_groups(270)
>    No rid for Account Operators !?
> 
> It adds a call to sid_check_is_in_builtin because the Builtin SIDs won't
> match the domain SID.
> 
> 
> The second is a re-implementation of a "feature" that I argued for in 3.0
> Alpha, but apparently lost.  It modifies lookup_groupmem for ADS so that it
> behaves the same as lookup_groupmem for RPC.
> 
> The RPC version returns all members of a group, whereas the current ADS
> version doesn't return members who have that group as their primary group.
> Consequently, lists of Domain Users is horribly short.
> 
> I need the list of group members to be consistent between RPC and ADS.  For
> others that need it, the second patch will give it to them.

Thanks Ken.  I'll review this and get back to you on Monday.




cheers, jerry
 ----------------------------------------------------------------------
 Hewlett-Packard            ------------------------- http://www.hp.com
 SAMBA Team                 ---------------------- http://www.samba.org
 GnuPG Key                  ---- http://www.plainjoe.org/gpg_public.asc
 "You can never go home again, Oatman, but I guess you can shop there."  
                            --John Cusack - "Grosse Point Blank" (1997)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: For info see http://quantumlab.net/pine_privacy_guard/

iD8DBQE/ELibIR7qMdg1EfYRAobGAJ9xFRIj5hXyXhg5nIra6IF5Gx2PuQCgu9x9
lv/PFC+oduq4dikxAGnwqEA=
=p+b5
-----END PGP SIGNATURE-----




More information about the samba-technical mailing list