winbindd: msrpc vs. ads methods & domain trusts between ADS and NT4

[Andrew Bartlett]

On Sat, 2003-06-07 at 04:38, Chere Zhou wrote:
> All right, I found what's wrong.  Now I need to know a proper way to fix it.
> 
> in winbindd_ads.c: 74:
> 	if (status.error_type == ADS_ERROR_SYSTEM &&
> 	        status.err.rc == ECONNREFUSED) {
>                         DEBUG(1,("Trying MSRPC methods\n"));
>                         domain->methods = &msrpc_methods;
>                 }
> 
> My NT4 PDC gives back the status.err.rc as EINVAL instead of ECONNREFUSED, 
> which caused the fall back to rpc never executed.
> 
> Can you tell me if I change the if statement to 
> 	if (status.error_type == ADS_ERROR_SYSTEM) {
> will I break some other scenarios?  Or, maybe I should go for 
> 	if (status.error_type == ADS_ERROR_SYSTEM &&
> 	    (status.err.rc == ECONNREFUSED || status.err.rc == EINVAL)) {

Can you mark this up in bugzilla (bugzilla.samba.org) so we don't forget
it?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20030706/c9998943/attachment.bin