Wrong usage of lp_idmap_backend() value?

Alexander Bokovoy a.bokovoy at sam-solutions.net
Wed Jul 2 16:16:30 GMT 2003


Greetings!

In smbd/server.c we are supposed to use value of 'idmap backend' option to
initialize idmap but code logic is different: it decides to override
everything in 'idmap backend' by 'winbind' unless 'idmap backend' is empty
in which case we supply NULL as argument to idmap_init().

Is it on purpose or wrong?

Index: source/smbd/server.c
===================================================================
RCS file: /home/cvs/samba/source/smbd/server.c,v
retrieving revision 1.372.2.27
diff -u -r1.372.2.27 server.c
--- source/smbd/server.c	27 Jun 2003 20:55:48 -0000	1.372.2.27
+++ source/smbd/server.c	2 Jul 2003 15:27:00 -0000
@@ -848,7 +848,7 @@
 	{
 		const char *idmap_back = lp_idmap_backend();
 
-		if (!idmap_init((idmap_back && *idmap_back) ? "winbind" : NULL))
+		if (!idmap_init((idmap_back && *idmap_back) ? idmap_back : "winbind"))
 			exit(1);
 	}
 

-- 
/ Alexander Bokovoy
---
QOTD:
	"If you keep an open mind people will throw a lot of garbage in it."



More information about the samba-technical mailing list