CVS update: samba/source/passdb

Jeremy Allison jra at
Tue Jul 1 17:29:14 GMT 2003

On Tue, Jul 01, 2003 at 07:03:54PM +0200, Volker Lendecke wrote:
> On Tue, Jul 01, 2003 at 05:01:15PM +0000, Jeremy Allison wrote:
> > > Running 'net cache list' or secrets_get_trusted_domains through
> > > valgrind gives a *huge* amount of invalid reads of one byte beyond the
> > > indicated string length in libc's strncpy. Annoying...
> > 
> > We should replace these with strlcpy. Much more logical interface.
> As far as I can see from the Samba implementation this would also 
> read over the non-null-terminated source string. It does a 
> size_t = strlen(s)

Hmmm. From checking the OpenBSD sources it seems the interface
expects src to be a null terminated string for strlcpy. So
maybe we can't change that interface. Oh well :-(.


More information about the samba-technical mailing list