Bug in nmbd_become_dmb.c (CVS 1.7 3.somehting) [patch]

Damjan "Zobo" Cvetko zobo at lana.krneki.org
Wed Jan 22 11:23:01 GMT 2003

I dont know if this is the rigth list for this..
I'm using the latest samba 3.x. from CVS.. (because of the wins replication)
I have it set up as master browser, but it wont register itself (to the WINS
server running in the same nmbd) as DMB (WROKGROUP#1b..)

I played arround the code a bit and filay did this:

Index: nmbd_become_dmb.c
RCS file: /cvsroot/samba/source/nmbd/nmbd_become_dmb.c,v
retrieving revision 1.17
diff -u -r1.17 nmbd_become_dmb.c
--- nmbd_become_dmb.c   12 Nov 2002 23:15:49 -0000      1.17
+++ nmbd_become_dmb.c   22 Jan 2003 11:00:56 -0000
@@ -375,7 +375,7 @@

   /* Do the domain master names. */
-  if(lp_server_role() == ROLE_DOMAIN_PDC)
+  if (lp_domain_master() == True)

Now it works..
I have no idea if this is the right wayto do it, but ROLE_DOMAIN_PDC is set
only if the config says it so (and I dont wat it)..
Plus 'lp_domain_master()' answers True if nmbd should be PDC.. so no
functionalyty should be lost..



More information about the samba-technical mailing list