Samba 3.0.1 Makefile broken on Solaris

[Brian Poole]

I've attached a patch that does the job for me.. not sure if the
workaround I removed still has any use for older versions of 
Solaris/SunOS. I tested this on Solaris 7 and found it fixed 
compilation. Have to regen configure after applying or edit 
configure directly.


-b

Quoting Gary Casterline (casterln at nature.Berkeley.EDU) from 18 December 2003:
> I had the same problem on Solaris 9 using gnu make and
> the Forte compiler.  When I switched to gcc everything
> compiled fine.  Is there a simple workaround to allow
> a Forte compilation?
> 
>  _Gary
> 
> On Tue, Dec 16, 2003 at 11:12:57AM -0500, Brian Poole wrote:
> > Hello,
> > 
> > The 3.0.1 source does not compile currently on Solaris. My testing
> > environment was using the Forte compiler & Sun make. The problem is
> > in the Makefile where it tries to move some non-existent files.
> > This can be seen on the Samba build farm:
> > 
> > http://build.samba.org/?function=View+Build&host=sun1&tree=samba_3_0&compiler=cc
> > 
> > The error looks like:
> >  
> > mv: cannot access nsswitch/wb_common.po.o.o
> > make: *** [nsswitch/wb_common.po.o] Error 2
> > 
> > The output file is of course not wb_common.po.o.o, but 
> > wb_common.po.o. Should be a relatively simple patch but I am unsure
> > of what the correct destination name is, so I did not make a patch.
> > If you just change the source name it would try to move 
> > wb_common.po.o to wb_common.po.o and error out because they are the 
> > same file.
> > 
> > This error occurs three times in the Makefile.in and was introduced
> > 2 months ago when PICSUFFIX was added:
> > 
> > http://cvs.samba.org/cgi-bin/cvsweb/samba/source/Makefile.in.diff?r1=1.721&r2=1.722
> > 
> > Wish I had compiled a release candidate now but I was waiting for the
> > smbclient output fix to be put in (which unfortunately didn't make it
> > for 3.0.1, from what I can tell.)
> > 
> > 
> > -b
-------------- next part --------------
--- configure.in.orig	Tue Dec 30 10:08:40 2003
+++ configure.in	Tue Dec 30 10:08:51 2003
@@ -163,7 +163,6 @@
 AC_SUBST(HOST_OS)
 AC_SUBST(PICFLAGS)
 AC_SUBST(PICSUFFIX)
-AC_SUBST(POBAD_CC)
 AC_SUBST(SHLIBEXT)
 AC_SUBST(INSTALLCLIENT)
 AC_SUBST(INSTALLCLIENTCMD_SH)
@@ -1062,7 +1061,6 @@
 SHLD="\${CC} \${CFLAGS}"
 PICFLAGS=""
 PICSUFFIX="po"
-POBAD_CC="#"
 SHLIBEXT="so"
 
 if test "$enable_shared" = "yes"; then
@@ -1096,7 +1094,6 @@
 				## ${CFLAGS} added for building 64-bit shared 
 				## libs using Sun's Compiler
 				LDSHFLAGS="-G \${CFLAGS}"
-				POBAD_CC=""
 				PICSUFFIX="po.o"
 			fi
 			AC_DEFINE(STAT_ST_BLOCKSIZE,512,[The size of a block])
--- Makefile.in.orig	Tue Dec 30 10:08:59 2003
+++ Makefile.in	Tue Dec 30 10:09:21 2003
@@ -737,7 +737,6 @@
 	@echo Compiling $*.c with @PICFLAGS@
 	@$(CC) -I. -I$(srcdir) $(FLAGS) $(PATH_FLAGS) @PICFLAGS@ -c $< -o $*. at PICSUFFIX@
 @BROKEN_CC@	-mv `echo $@ | sed -e 's%^.*/%%g' -e 's%\. at PICSUFFIX@$$%.o%'` $@
- at POBAD_CC@	@mv $*. at PICSUFFIX@.o $@
 
 lib/version.o: lib/version.c include/version.h
 	@echo Compiling $*.c
@@ -749,7 +748,6 @@
 	@echo Compiling $*.c with @PICFLAGS@
 	@$(CC) -I. -I$(srcdir) $(FLAGS) $(PATH_FLAGS) @PICFLAGS@ -c $< -o $*. at PICSUFFIX@
 @BROKEN_CC@	-mv `echo $@ | sed -e 's%^.*/%%g' -e 's%\. at PICSUFFIX@$$%.o%'` $@
- at POBAD_CC@	@mv $*. at PICSUFFIX@.o $@
 
 smbd/build_options.o: smbd/build_options.c Makefile include/config.h include/build_env.h include/proto.h
 	@echo Compiling $*.c
@@ -765,7 +763,6 @@
 	@echo Compiling $*.c with @PICFLAGS@
 	@$(CC) -I. -I$(srcdir) $(FLAGS) @PICFLAGS@ -c $< -o $*. at PICSUFFIX@
 @BROKEN_CC@	-mv `echo $@ | sed -e 's%^.*/%%g' -e 's%\. at PICSUFFIX@$$%.o%'` $@
- at POBAD_CC@	@mv $*. at PICSUFFIX@.o $@
 
 bin/.dummy:
 	@if (: >> $@ || : > $@) >/dev/null 2>&1; then :; else \