It's time for 3.0.1
David Collier-Brown
David.Collier-Brown at Sun.COM
Mon Dec 8 18:32:18 GMT 2003
I found a small Solaris-vs-configure problem in samba-3.0.1pre3,
and the 3.0.0 production release, with HAVE_OFF64_T coming out as
false in Solaris, and breaking quotas.
I'm waiting for the customer with broken quotas to confirm
my diagnosis, but my reasoning is as follows:
---
int sys_stat(const char *fname,SMB_STRUCT_STAT *sbuf)
{
int ret;
#if defined(HAVE_EXPLICIT_LARGEFILE_SUPPORT) && defined(HAVE_OFF64_T) &&
defined(HAVE_STAT64)
ret = stat64(fname, sbuf);
#else
ret = stat(fname, sbuf);
#endif
---
This causes the 32-bit stat struct to be used, and a quota
lookup to fail whenever the values are greater than 2^32.
On 64-bit Solaris 8 or 9, configure produces a config.h with:
---
* Whether large file support can be enabled */
#define HAVE_EXPLICIT_LARGEFILE_SUPPORT 1
/* Whether off64_t is available */
/* #undef HAVE_OFF64_T */
/* Whether stat64() is available */
#define HAVE_STAT64 1
---
The SMB_DEV_T used will also be a 32-bit value, as
#if defined(HAVE_EXPLICIT_LARGEFILE_SUPPORT) && defined(HAVE_DEV64_T)
will fail.
I strongly suspect the configure program is getting this wrong,
and am tracing it as we speak... report as soon as I know more
--dave
Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> As soon as
>
> ~ a) I can resolve the issue reported by
> ~ Aurélien Degrémont (lookup sids failing) to
> ~ one degree or another, I am planning on
> ~ b) I can get some Fredora Core 1 packages building, i'm
> ~ going to release 3.0.1rc2. I believe that rc2
> ~ will hold up and will become 3.0.1 after a few days
> ~ of stress testing.
>
> So there is about another 24 hours of testing rc1.
>
> Then we move on to 3.0.2 :-)
>
> Thanks to everyone for their work on 3.0.1. I know we
> all needed some time off after 3.0.0, but its good to
> see the work continueing to improve the innitial .0 release.
>
>
>
>
> cheers, jerry
> ~ ----------------------------------------------------------------------
> ~ Hewlett-Packard ------------------------- http://www.hp.com
> ~ SAMBA Team ---------------------- http://www.samba.org
> ~ GnuPG Key ---- http://www.plainjoe.org/gpg_public.asc
> ~ "If we're adding to the noise, turn off this song" --Switchfoot (2003)
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.1 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iD8DBQE/1L+CIR7qMdg1EfYRAs9LAKCPqDuZ+wiAsJPPHUTmWsxSr3ef6wCglGZo
> x+w2nUha5aewehoQAOupXaU=
> =DA9C
> -----END PGP SIGNATURE-----
>
--
David Collier-Brown, | Always do right. This will gratify
Sun Microsystems, | some people and astonish the rest.
Toronto, Ontario, | -- Mark Twain
(905) 415-2849 or x52849 | davecb at canada.sun.com
More information about the samba-technical
mailing list