browselist comments are truncated 12 bytes

[Christopher R. Hertel]

On Fri, Aug 29, 2003 at 05:24:35PM +0000, Jeremy Allison wrote:
> On Sat, Aug 30, 2003 at 02:14:00AM +0900, TAKAHASHI Motonobu wrote:
> > 
> > During examining BUG#221, I found a bug?
> > 
> > At nmbd_incomingdgrams.c:111 there is a line 
> > 
> >     comment[12] = 0;
> > 
> > This makes browselist comment truncated 12 bytes.
> > For example, "Samba CVS 3.0.0rc2" becomes "Samba CVS 3.".
> > 
> > Why was this change committed?
> 
> My mistake. I was reading the original code when fixing
> nmbd w.r.t. mb character set issues and wanted to ensure
> I didn't change the behaviour. I'll check in the 2.2
> codebase but it looked like the same was done there. If
> not please log a bug and I'll fix it asap.

Hmmm...  Share names are limited to 12 bytes in RAP, though the RAP data 
descriptor string lists 13 bytes to account for a nul terminator.  Could 
there be some confusion between the share name and comment fields?

Just a wild guess...

Chris -)-----

-- 
"Implementing CIFS - the Common Internet FileSystem" ISBN: 013047116X
Samba Team -- http://www.samba.org/     -)-----   Christopher R. Hertel
jCIFS Team -- http://jcifs.samba.org/   -)-----   ubiqx development, uninq.
ubiqx Team -- http://www.ubiqx.org/     -)-----   crh at ubiqx.mn.org
OnLineBook -- http://ubiqx.org/cifs/    -)-----   crh at ubiqx.org