browselist comments are truncated 12 bytes

Jeremy Allison jra at samba.org
Fri Aug 29 17:24:35 GMT 2003


On Sat, Aug 30, 2003 at 02:14:00AM +0900, TAKAHASHI Motonobu wrote:
> 
> During examining BUG#221, I found a bug?
> 
> At nmbd_incomingdgrams.c:111 there is a line 
> 
>     comment[12] = 0;
> 
> This makes browselist comment truncated 12 bytes.
> For example, "Samba CVS 3.0.0rc2" becomes "Samba CVS 3.".
> 
> Why was this change committed?

My mistake. I was reading the original code when fixing
nmbd w.r.t. mb character set issues and wanted to ensure
I didn't change the behaviour. I'll check in the 2.2
codebase but it looked like the same was done there. If
not please log a bug and I'll fix it asap.

Jeremy.



More information about the samba-technical mailing list