[PATCH] updates for examples/VFS/*

[Stefan (metze) Metzmacher]

At 15:22 10.08.2003 +0200, Stefan (metze) Metzmacher wrote:
>At 15:12 10.08.2003 +0200, Jelmer Vernooij wrote:
>>Hi Stefan!
>>
>> > here's my patch for examples/VFS/*
>>Looks good! I have some small comments.
>>
>> > 1) configure autodetect the samba version from include/version.h
>> > this can be overwritten with configure --with-samba-version="3.0.0rc1cvs"
>> > for vendors which changed include/version.h
>> >
>> > there
>> > SAMBA_VERSION_MAJOR
>> > SAMBA_VERSION_MINOR
>> > SAMBA_VERSION_REALEASE
>> > ...
>> > macros is module_config.h defined  then
>>There is a lot of code duplication between aclocal.m4 in the VFS
>>directory and source/.
>
>Yes, that's because I want module writers be independent of the samba source
>during autogen.sh
>
>And I think that's ok...

I have update the version detection code to deal with the "[PATCH] 
autogenerate inlcude/version.h" patch

>> > 2) I add a skel_compat module which compiles on 2.2.* and 3.0.*
>>This one looks kinda confusing to me - have you asked Alexander's
>>opinion on this one?
>
>Alexander,
>have you comments on the skel_compat module?
I have dropped this for now.


metze
-----------------------------------------------------------------------------
Stefan "metze" Metzmacher <metze at metzemix.de> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3_0-ver-mod-01.patch
Type: application/octet-stream
Size: 43732 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20030811/07dc5c21/3_0-ver-mod-01.obj