segfaults in pam_smbpass in SAMBA_3_0 with unixsam backend
jelmer at nl.linux.org
Fri Oct 25 02:46:35 GMT 2002
On Thu, Oct 24, 2002 at 08:26:26PM -0500, Steve Langasek wrote about 'Re: segfaults in pam_smbpass in SAMBA_3_0 with unixsam backend':
> On Fri, Oct 25, 2002 at 02:39:16AM +0200, Jelmer Vernooij wrote:
> > On Thu, Oct 24, 2002 at 06:51:38PM -0500, Steve Langasek wrote about 'segfaults in pam_smbpass in SAMBA_3_0 with unixsam backend':
> > > Currently, pam_smbpass calls initialize_password_db() with reload == True
> > > on every pass through the module. This is supposedly the Right Thing
> > > for the code to do, but recently the "reload" option took on actual
> > > meaning, and now pam_smbpass segfaults on the second pass when using
> > > the unixsam backend. :)
> > > The nisplus and unixsam backends do not initialize the free_private_data
> > > method. Do these need to be implemented yet, or should they be stubbed
> > > off and have error checking added to free_pdb_context() to check for a
> > > null pointer?
> > Fixed. (Needed to check for a null pointer, as happens in all other passdb
> > functions)
> > Thanks for reporting!
> And thanks for the quick fix. There's still a problem in the nisplus
> backend, I believe; a chunk of private_data is allocated but never
> freed. Fortunately, this is a mere memory leak, and not a segfault. :)
It's in, thanks!
If you do have a nisplus server there, could you re-check whether
nisplussam works 100% correctly? I converted it to the new passdb
interface at CIFS this summer, but I haven't been able to test it
since I don't have a nisplus server around.
More information about the samba-technical