[PATCH] winbind id assignment module

Andrew Bartlett abartlet at pcug.org.au
Sat May 18 17:58:01 GMT 2002

Mike Gerdts wrote:
> On Sat, 2002-05-18 at 20:05, Andrew Bartlett wrote:
> > I don't think I actually looked at the code for the first patch, only
> > the comments.  Unless a patch is *really* big (in which case you should
> > consider why this is the case) you would do well to always include the
> > patch an either an inline or attached diff, not as a tarball.
> I am confused on list etiquette... I thought that samba-technical was
> one that everyone complained about attachments 'cause it screwed up the
> -digest version.

They complain about binary attachments, and html mail.  Patches havn't
caused an issue as far as I know.  Works best if you can convince your
mailer to attach it (as yours did) in a 'text/...' format, as then it
doesn't get encoded etc.

> The patch and a sample module are attached.  The tarball also includes a
> readme, changelog, and a Makefile.

This looks *much* better.

I'm not sure on the 'reload' functionality, but I suppose its a good
idea.  Other than minor things like indenting,   (Try 8-space tabs) I
think this is well on its way to inclusion.

I like the checking of the .so at loadparm time - its a nice touch.

Andrew Bartlett

Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net

More information about the samba-technical mailing list