[patch] sec_desc for cvs HEAD

Andrew Tridgell tridge at samba.org
Wed Jan 30 22:43:16 GMT 2002


That patch looks much better. One minor problem is the LDAPMod type
outside of ldap.c. That means that Samba won't compile on systems
without LDAP, as these functions get placed into proto.h. The simple
fix is to make ads_init_mods(), ads_free_mods() etc static, which
means they are not exposed outside of that module. They are not called
from anywhere else so they should be static anyway. If you really do
need them exposed for some reason then you'll need to use a void* and
cast to LDAPMod* inside the functions like I have done with the other
ldap functions to avoid exposing the internals of the LDAPMod type on
non-ldap systems.

I'm not quite sure why you are doing:

#ifndef _AD_OID

in smb.h. Is this really needed? Why? 

Finally, it would be nice to use a talloc context (eg. the one in the
prs struct, or even a new one) instead of all those allocates and
frees, but that isn't critical.

Thanks for your efforts on this patch!

Cheers, Tridge

More information about the samba-technical mailing list