[patch] sec_desc for cvs HEAD

Andrew Tridgell tridge at samba.org
Wed Jan 30 22:42:15 GMT 2002


Cat,

One other problem I just noticed. Some of your code is still
intel-specific. For example the following in sec_desc_dump_len()

	/* copy SD header */
	n = SEC_DESC_HEADER_SIZE;
	memcpy(ret, sd, n);
	p += n;

copies direct from a structure that can be a different byte order or a
different shape on other systems. I'm afraid you really do need to use
code similar to the parse code or use the SVAL() macros.

Do you have a sparc, MIPS or other non-intel machine that you can test
on?

Cheers, Tridge




More information about the samba-technical mailing list