Samba 2.2.3 and offline folders with W2K SP2

[Jeremy Allison]

On Mon, Feb 18, 2002 at 06:46:10PM +0100, Beschorner Daniel wrote:
> Hi!
> 
> Here is a scenario where Samba 2.2.3a fails, but 2.2.2 succeeds:
> 
> 1. make a samba folder in W2K SP2 offline available
> 2. disconnect from network, go offline
> 3. create a sample file on client, i.e. a simple text file
> 4. you can access it
> 5. go online and synchronize files
> 6. still can access it
> 7. go offline again
> 8. "access denied" message appears when try to open the file offline
> 
> "nt acl support" doesn't matter, only two ways out: downgrade server to
> 2.2.2 or uninstall SP2 on client

Thanks for the excellent bug report.

I've nailed this I think - here's the patch for 2.2.3a.

Please test and report back.

Jeremy.

--- smbd/nttrans.c.orig Wed Feb 27 12:34:12 2002
+++ smbd/nttrans.c      Wed Feb 27 12:34:58 2002
@@ -909,8 +909,8 @@
        if(oplock_request && EXCLUSIVE_OPLOCK_TYPE(fsp->oplock_type))
                smb_action |= EXTENDED_OPLOCK_GRANTED;

-#if 1 /* JRATEST */
-       /* W2K sends back 42 words here ! */
+#if 0
+       /* W2K sends back 42 words here ! If we do the same it breaks offline sync. Go figure... ? JRA. */
        set_message(outbuf,42,0,True);
 #else
        set_message(outbuf,34,0,True);