static functions

[Claudia Moroder]

Hello Simon,

I give up. May be there are functions I can see if they are only local (
MD5Transform probably is ) . For most of them a expert is needed, so I am
the wrong one. If YOU are interested I can post a list of functions called
only locally but not defined as static.
Bye
Andreas
-----Ursprüngliche Nachricht-----
Von: "Simo Sorce" <idra at samba.org>
An: "andreas moroder" <claudiamoroder at st-ulrich.suedtirol.net>
Cc: <samba-technical at lists.samba.org>
Gesendet: Sonntag, 24. Februar 2002 16:07
Betreff: Re: static functions


> This is agood idea, but change into static only those functions that are
clearly intebded to be used only in that .c file, not those that are
intended for general use but are used only in that file at the moment.
>
> On Sun, Feb 24, 2002 at 03:02:06PM +0100, andreas moroder wrote:
> > Hello,
> >
> > the documentations tells us to use static functions where possible.
> > While doing other tings I found functions that are used only locally,
but are
> > not defined as static, like
> >
> > groupdb/mapping.c add_all_privilege
> > groupdb/mapping.c check_empty_privilege
> > lib/username.c:   Get_Pwnam_internals
> > lib/md5.c:        MD5Transform
> > ./lib/util_str.c:smb_ucs2_t *all_string_sub_w
> > ./printing/printing.c:void broadcast_printer_notify
> > ./rpc_server/srv_pipe.c:BOOL check_bind_req
> >
> > would it be ok if I prepare a patch for all funtions used only locally
and
> > not defined as static ?
> >
> > Bye
> > Andreas
> >
>
> --
> Simo Sorce       idra at samba.org
> -------------------------------
> Samba Team http://www.samba.org