static functions

Simo Sorce idra at
Sun Feb 24 07:08:05 GMT 2002

This is agood idea, but change into static only those functions that are clearly intebded to be used only in that .c file, not those that are intended for general use but are used only in that file at the moment.

On Sun, Feb 24, 2002 at 03:02:06PM +0100, andreas moroder wrote:
> Hello,
> the documentations tells us to use static functions where possible.
> While doing other tings I found functions that are used only locally, but are 
> not defined as static, like
> groupdb/mapping.c add_all_privilege
> groupdb/mapping.c check_empty_privilege
> lib/username.c:   Get_Pwnam_internals
> lib/md5.c:        MD5Transform
> ./lib/util_str.c:smb_ucs2_t *all_string_sub_w
> ./printing/printing.c:void broadcast_printer_notify
> ./rpc_server/srv_pipe.c:BOOL check_bind_req
> would it be ok if I prepare a patch for all funtions used only locally and 
> not defined as static ?
> Bye
> Andreas

Simo Sorce       idra at
Samba Team

More information about the samba-technical mailing list