smb_receive problem with 2.2.3
jra at samba.org
Sat Feb 23 13:03:02 GMT 2002
On Fri, Feb 15, 2002 at 10:33:50AM -0800, Tim Potter wrote:
> On Fri, Feb 15, 2002 at 10:53:09AM -0600, Esh, Andrew wrote:
> > While doing a number of tests, one of my associates found the cause
> > of the failure of one our Samba file access torture tests. I am wondering
> > why the code to return READ_ERROR was added to smb_receive.
> This code was added to stop smbclient returning "error code 0" when the
> remote server was failing to respond to keepalive packets.
> It sounds like this is having unintended consequences so it should
> probably be backed out.
Yes, the problem is that one of the lower level functions is
already setting smb_read_error, and it's getting overwritten
above. The correct fix is to only set it if smb_read_error is
still zero, and I've just committed this fix to 2.2.x and HEAD,
overwriting the previous change.
More information about the samba-technical