question about byteorder.h

andreas moroder claudiamoroder at st-ulrich.suedtirol.net
Sun Feb 10 06:06:02 GMT 2002


Hello,

would it be possible to make the following change in byteorder.h ?

#define SSVALX(buf,pos,val) 
(CVAL_NC(buf,pos)=(val)&0xFF,CVAL_NC(buf,pos+1)=(val)>>8)

to 
#define SSVALX(buf,pos,val) (CVAL_NC(buf,pos)=(unsigned char) 
((val)&0xFF),CVAL_NC(buf,pos+1)=(unsigned char)((val)>>8))

this because CVAL_NC assigns to a unsigned char. Splint would be happier and 
the code does remains readable.

Bye
Andreas






More information about the samba-technical mailing list