tdb corruption with "use mmap=false"

[MCCALL,DON (HP-USA,ex1)]

Hi Jeremy,
I pulled the patch; and it will probably 'fix' reinout's problem with lotus
notes, BUT - if I'm reading this right, if the offset (not the count) is >
31 bits, we return success, but never actually try the fcntl lock.
Isn't this going to be a problem when we are really counting on an fcntl
lock on the file?  What am I missing?

btw, I tested using smbtorture: here is a snippet from the debug log to show
the code working:
[2001/09/07 13:36:51, 0] locking/posix.c:(668)
  posix_fcntl_lock: WARNING: lock request at offset 2190433271, length 1
returne
d
[2001/09/07 13:36:51, 0] locking/posix.c:(670)
  an No locks available error. This can happen when using 64 bit lock
offsets
[2001/09/07 13:36:51, 0] locking/posix.c:(671)
  on 32 bit NFS mounted file systems.
[2001/09/07 13:36:51, 0] locking/posix.c:(679)
  Offset greater than 31 bits. Returning success.


Thanks,
Don

-----Original Message-----
From: Jeremy Allison [mailto:jeremy at valinux.com]
Sent: Thursday, September 06, 2001 6:40 PM
To: MCCALL,DON (HP-USA,ex1)
Cc: 'samba-technical at lists.samba.org'
Subject: Re: tdb corruption with "use mmap=false"


Don,

	I've just checked in a fix for the 64 bit lock offset
onto a 32 bit NFS mount problem an HPUX user found. Could you
please give it a test (it's in the 2.2.2 and HEAD CVS branches).

Thanks,

	Jeremy.