Every 6 minutes ... broken pipe

[Neil Hoggarth]

On Wed, 21 Mar 2001, David Collier-Brown wrote:

> 	Ok set keepalive = 0 in the globals section
> 	of you smb.conf.
>
> 	Samba team: should I produce a patch that
> 	makes keepalive = 0 the default iff security = server?

Does anyone know why smbd sends keepalives to a password server?
Neither the security=server smbd nor the authentication server smbd seem
to actually do anything with the messages, unless I'm missing something.

Unless someone stands up to defend password server keepalives, I would
argue that the cleanest change would be to simply do away with them.
:-)

Trivial diff against HEAD follows ...

--- source/smbd/process.c.orig	Wed Mar 21 15:50:15 2001
+++ source/smbd/process.c	Wed Mar 21 15:51:29 2001
@@ -1094,10 +1094,6 @@
       DEBUG( 2, ( "Keepalive failed - exiting.\n" ) );
       return False;
     }
-    /* also send a keepalive to the password server if its still
-       connected */
-    if (cli && cli->initialised)
-      send_keepalive(cli->fd);
     last_keepalive_sent_time = t;
   }

Regards,
-- 
Neil Hoggarth                                 Departmental Computer Officer
<neil.hoggarth at physiol.ox.ac.uk>                   Laboratory of Physiology
http://www.physiol.ox.ac.uk/~njh/                  University of Oxford, UK