free disk space bug in 2.2

[Michael Gerdts]

On Fri, Jun 29, 2001 at 09:57:52AM -0400, David Collier-Brown wrote:
> Patrick Scharrenberg and I have been discussing a bug in quotas on
> 2.2.
> 
> Patrick Scharrenberg wrote:
> > > | If I have quotas enabled, samba 2.2 tells the windows client
> > > | the right amount of free quota disk space.
> > > | But if the real disk space is lower then the quota space, the
> > > | system still tells the free quota value.
> 
> After some additional testing, he wrote:
> > I have a user without quotas => Win2k reports 5.29 Gig of free disk space,
> > which is correct
> > but when I enable 10 GIG of quotas for this user => win2k reports 9,53 gig
> > of free space :-((
> > Linux Kernel is 2.4.5
> > Samba is 2.2.0
> 
> 	This implies something seriously bogus, as the
> 	code says 
> 		(*dfree) = MIN(*dfree,dfree_q);
> 	which should[1] work.

What do you mean by "10 GIG"?  Is that 10 * 1000 * 1000 * 2 * 512 (
2,000,000 blocks) or is that 10 * 1024 * 1024 * 2 * 512?  Note that
9.53 * 1024/1000 * 1024/1000 = 9.99292928.

Sounds like a bug in definition of what a gigabyte is rather than a bug in
Samba.

Mike