[bug] simple but severe coding bugs of rpcclient

[Samba-JP TAKAHASHI Motonobu]

On Sun, 24 Jun 2001, Tim Potter wrote:
> The rpcclient program in 2.0/2.2 is pretty broken.  I've been
> working on a new implementation, with the libsmb directory.  

On Sun, 24 Jun 2001, Gerald Carter wrote:
>2.2 should be using the new code IIRC.  Not as current as HEAD
>but the structure was the same (or are you rewriting it again :) )

I think this problem is critical for rpcclient, but not important.

This problem was found during the test for the Jeremy's mail:

-----
> There are similar coding in dos_buffer2_to_str() and
> dos_buffer2_to_multistr(), we suspect there is another bug...

I also
fixed the same errors in the other two functions. Please
check out the 2.2 CVS and see if it fixes the problem.
-----

These two functions are called only from rpcclient, so first we tried
to execute rpcclient and met this bug and the bug already reported in
"[bug] invalid usage display of rpcclient".

And another multibyte bug around dislaying messages was found during
this test and I will report later with a patch.

-----
TAKAHASHI Motonobu                    mailto:monyo at samba.gr.jp
Samba Users Group Japan               http://www.samba.gr.jp/