a question about negprot.c:reply_nt1()

Simo Sorce idra at samba.org
Sat Jun 23 14:07:32 GMT 2001


parsing the build farm error log of some machines I've seen this error:
smbd/negprot.c: In function `reply_nt1':
smbd/negprot.c:176: warning: `data_len' might be used uninitialized in this function

well in the function data_len is declared this way:
  int data_len;

and used only there:

  SSVAL(outbuf,smb_vwv17,data_len); /* length of challenge+domain strings */

and never initialized.
is it ok?


previous revision had also the following lines: 
1.10          tridge     215:   data_len = crypt_len + strlen(global_myworkgroup) + 1;
1.1           tridge     216: 
                         217:   set_message(outbuf,17,data_len,True);


-- 
Simo Sorce       idra at samba.org
-------------------------------
Samba Team http://www.samba.org




More information about the samba-technical mailing list