patch for broken "printing" option

[Shahms E. King]

Oops, that's most cetainly not the fix, however the problem with either 
the printing option resulting in non-intuitive results, combined with 
what appears to me to be the "printcap name" option doing things that 
would be better determined by the "printing" option . . .

or at least documented ;-)

sorry about the undue traffic

--Shahms


Shahms E. King wrote:

> At present, the printing = option does not seem (IMHO) to do the right 
> thing.  In fact, it doesn't seem to do anythign at all.
> 
> The root of the problem is that init_printer_values() is called from 
> init_globals() which is called before the config file is read.  The 
> other half of the problem is that init_printer_values() is the ONLY 
> place where the value of sDefaults.iPrinting is used, in fact, it's used 
> here to initialize Globals.szPrintcapname, which is used everywhere else 
> to determine how to print.
> 
> Whether this is this patch is the best solution, can't say, but it seems 
> to behave in a much more intuitive manner than before.
> 
> --Shahms
> 
> 
> --- samba-2.2.1a/source/param/loadparm.c.orig    Thu Jul 12 16:03:45 2001
> +++ samba-2.2.1a/source/param/loadparm.c    Thu Jul 12 15:44:08 2001
> @@ -3285,6 +3285,8 @@
>          if (iServiceIndex >= 0)
>           bRetval = service_ok(iServiceIndex);
>     
> + init_printer_values();
> +
>      lp_add_auto_services(lp_auto_services());
> 
>      if (add_ipc) {
> 
>