nt_printing.c

[Gerald Carter]

On Sun, 1 Jul 2001, Osama Abu-Aish wrote:

> Hi out there!
>
> The following code from nt_printing.c killed my NT clients when
> any user connected to a shared printer (explorer.exe freezes):
>
> if (!lookup_name( "Printer Administrators", &owner_sid, &name_type) &&
>    !lookup_name( "Administrators", &owner_sid, &name_type) &&
>    !lookup_name( "Administrator", &owner_sid, &name_type) &&
>    !lookup_name("root", &owner_sid, &name_type)) {
>    sid_copy(&owner_sid, &global_sid_World);
> }

Yeah.  Tim already fixed this in SAMBA_2_2 CVS tree I think.
Hold on...[checks code...]

Yeah.  Looks ok.

> Two questions:
>
> 1.) Why doesn't samba return from the failed name lookup?
> 2.) Shouldn't we use a well-known SID instead of doing locale-dependent
>      name lookups?

#2 was the solution.







Cheers, jerry
 ---------------------------------------------------------------------
 http://www.valinux.com/     VA Linux Systems      gcarter at valinux.com
 http://www.samba.org/          SAMBA Team             jerry at samba.org
 http://www.plainjoe.org/                           jerry at plainjoe.org
 --"I never saved anything for the swim back." Ethan Hawk in Gattaca--