Samba 2.2.0 alpha 3 buglets in smbwrapper/smbw_dir.c

Jeremy Allison jeremy at
Tue Apr 10 16:19:15 GMT 2001

David Collier-Brown wrote:
> My copy of smbw_dir.c says, at line 81:
> static void smbw_dir_add(struct file_info *finfo, const char *mask,
> void * NULL)
>         The trailing NULL looks exceeding strange (;-))
> In addition, there are NULLs on the ends of:
> cli_NetServerEnum(&srv->cli, srv->server_name, SV_TYPE_DOMAIN_ENUM,
>                                   smbw_server_add, NULL);
> cli_RNetShareEnum(&srv->cli, smbw_share_add, NULL);
> and
> (cli_list(&srv->cli, mask, aHIDDEN|aSYSTEM|aDIR,
>                              smbw_dir_add, NULL)
>         methinks a sed script got overenthusuastic...
>         Fixing the first and last were necessary to ge
>         a compile.

Ok - try checking out 2.2 again, I think I've fixed these.
They look like breakage introduced by the new smbclient library
that shouldn't be in 2.2 yet.


Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.

More information about the samba-technical mailing list