Samba 2.2.0 alpha 3 buglets in smbwrapper/smbw_dir.c

David Collier-Brown davecb at canada.sun.com
Tue Apr 10 17:57:22 GMT 2001


My copy of smbw_dir.c says, at line 81:
static void smbw_dir_add(struct file_info *finfo, const char *mask,
void * NULL)
	The trailing NULL looks exceeding strange (;-))


In addition, there are NULLs on the ends of:
cli_NetServerEnum(&srv->cli, srv->server_name, SV_TYPE_DOMAIN_ENUM,
				  smbw_server_add, NULL);
cli_RNetShareEnum(&srv->cli, smbw_share_add, NULL);
and
(cli_list(&srv->cli, mask, aHIDDEN|aSYSTEM|aDIR, 
			     smbw_dir_add, NULL)

	methinks a sed script got overenthusuastic...
	Fixing the first and last were necessary to ge 
	a compile.

--dave
-- 
David Collier-Brown,           | Always do right. This will gratify 
Performance & Engineering Team | some people and astonish the rest.
Americas Customer Engineering  |                      -- Mark Twain
(905) 415-2849                 | davecb at canada.sun.com




More information about the samba-technical mailing list