bug in params.c

John M Trostel jtrostel at mindspring.com
Sat Oct 14 17:30:40 GMT 2000


---Reply to mail from Osama Abu-Aish about bug in params.c
Wouldn't 

for( c=mygetc(Infile); ('\n'!=c) && (EOF!=c) && (c!=0); c=mygetc(InFile) )

accomplish the same thing while skipping over NULLs as the first code
snippet did?

> Hi all out there,
> 
> I've found a nasty bug in params.c:
> 
> Function EatComment consists of the following line:
>    for( c > InFile ) )
>                                                                      
> ^^^^^^^^^^^
> the (c>0) comparison fails for German umlauts, therefore EatComment returns
> and the rest of the services file cannot be parsed anymore. In my case the
> umlaut was in a comment in the [global] section so no services were available
> at all. I fixed it by omitting the (c>0) comparison:
> 
>    for( c > 
> Greetings, Osama
> 
> ---
> Fachhochschule für Technik Esslingen
> Außenstelle Goeppingen

---End reply
-- 
John M. Trostel
Linux OS Engineer
Connex
jtrostel at connex.com






More information about the samba-technical mailing list