bug in params.c

Osama Abu-Aish osabmt00 at fht-esslingen.de
Sat Oct 14 23:02:14 GMT 2000


Hi all out there,

I've found a nasty bug in params.c:

Function EatComment consists of the following line:
   for( c = mygetc( InFile ); ('\n'!=c) && (EOF!=c) && (c>0); c = mygetc( InFile ) )
                                                                      ^^^^^^^^^^^
the (c>0) comparison fails for German umlauts, therefore EatComment returns
and the rest of the services file cannot be parsed anymore. In my case the
umlaut was in a comment in the [global] section so no services were available
at all. I fixed it by omitting the (c>0) comparison:

   for( c = mygetc( InFile ); ('\n'!=c) && (EOF!=c) ; c = mygetc( InFile ) )

Greetings, Osama

---
Fachhochschule für Technik Esslingen
Außenstelle Goeppingen




More information about the samba-technical mailing list